On Fri, Mar 10, 2017 at 05:20:11PM -0800, Florian Fainelli wrote:
> On 03/10/2017 05:07 PM, Tim Harvey wrote:
> > On Fri, Mar 10, 2017 at 12:43 PM, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:
> >>
> >>> + dsa {
> >>> + compatible = "marvell,dsa";
> >>> + #address-cells = <2>;
> >>> + #size-cells = <0>;
> >>> +
> >>> + dsa,ethernet = <&fec>;
> >>> + dsa,mii-bus = <&mdio>;
> >>> +
> >>
> >> Please consider using the new binding for DSA switches, see:
> >>
> >> https://patchwork.kernel.org/patch/9493037/
> >>
> >
> > Hi Florian,
> >
> > I tried the new binding first, but haven't gotten it to work yet. Let
> > me make sure I understand what I should be doing.
> >
> > This is a MV88E6176 so I first need to add dt support for that to the
> > mv88e6xxx driver (which supports the device, just not via dt):
Hi Tim
Nope. The 6176 is compatible with the 6085.
> > Then I remove the old binding and add the new binding as such:
> >
> > &fec {
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_enet>;
> > phy-mode = "rgmii-id";
> > status = "okay";
>
> You most likely need to declare a fixed PHY for the FEC to be setting up
> the link, speed and duplex?
Take a look at arch/arm/boot/dts/vf610-zii-dev* as an example. This
uses a vf610, so is somewhat similar to the imx6. Same fec driver, but
the mdio is more complex due to there being 3 switches.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
