On Friday 20 December 2013 09:43 PM, Tony Lindgren wrote:
* Mark Brown <broonie@xxxxxxxxxx> [131220 08:10]:
On Fri, Dec 20, 2013 at 07:57:21AM -0800, Tony Lindgren wrote:
* Balaji T K <balajitk@xxxxxx> [131220 01:49]:
But interrupt was never used/tested AFAIK, there is some settling time
before the generated interrupt status is truely valid, so pbias interrupt is not
reliable.
OK. Do we need the standard regulator property startup-delay-us for the
PBIAS regulator then? Or if it's always fixed, I guess it could be done
in the pbias_regulator_enable()?
That delay is supposed to be the time for the startup of the supply
rather than any detection code. It should be set using enable_time in
the driver if it's not system dependent - the property is there for
cases where the delay depends on system configuration (eg, due to the
capacitor values).
OK thanks. Let's try enable_time first then as we've had a fixed value
for years for it. If there's some difference based on the card
capacitance etc that can be added if needed.
I used regulator-enable-ramp-delay to set constraints->enable_time based on SoC.
Since it is not board dependent, I will drop regulator-enable-ramp-delay from dt and
pass the value via driver_data.
Thanks and Regards,
Balaji T K
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
