Hi Rob, On Tue, Mar 07, 2017 at 10:03:37AM -0600, Rob Herring wrote: > On Sat, Mar 4, 2017 at 5:58 AM, Sebastian Reichel <sre@xxxxxxxxxx> wrote: > > Add method to get current CTS line state. > > > > Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx> > > --- > > drivers/tty/serdev/core.c | 11 +++++++++++ > > drivers/tty/serdev/serdev-ttyport.c | 15 +++++++++++++++ > > include/linux/serdev.h | 6 ++++++ > > 3 files changed, 32 insertions(+) > > > > diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c > > index a63b74031e22..36eb3dfb1477 100644 > > --- a/drivers/tty/serdev/core.c > > +++ b/drivers/tty/serdev/core.c > > @@ -184,6 +184,17 @@ void serdev_device_wait_until_sent(struct serdev_device *serdev, long timeout) > > } > > EXPORT_SYMBOL_GPL(serdev_device_wait_until_sent); > > > > +bool serdev_device_get_cts(struct serdev_device *serdev) > > I wonder if this should just be the wait for cts in the core. I think > that would be the common use for reading the CTS state. IIRC, I saw > some other device needing the same thing. mh. I think it fits nicely to serdev_device_set_rts(). But I guess it makes sense to have the wait feature directly in serdev. So I suggest to add the function in addition to the simple get_cts function. Does that make sense to you? -- Sebastian
Attachment:
signature.asc
Description: PGP signature
