On Fri, 3 Mar 2017 11:27:34 +0000 Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> wrote: > On 02/03/17 19:50, Alban wrote: > > Add the binding to expose MTD partitions as nvmem providers. > > It would be nice to see more description of this patch, explaining the > real use case. I'll try, writing good documentation is not my strong point :/ > > > > Signed-off-by: Alban <albeu@xxxxxxx> > > --- > > .../devicetree/bindings/nvmem/mtd-nvmem.txt | 29 ++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt > > > > diff --git a/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt b/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt > > new file mode 100644 > > index 0000000..47602f7 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt > > @@ -0,0 +1,29 @@ > > += NVMEM in MTD = > > + > > +Config data for drivers is often stored in MTD devices. This binding > > +define how such data can be represented in device tree. > > + > > +An MTD can be defined as an NVMEM provider by adding the `nvmem-provider` > We should prefix this property with "mtd" to make it more explicit that > this is specific to mtd devices. > > May be we should put this under "Required Properties" section, marking > it as mandatory for mtd nvmem providers. I agree it should be required, but I would not make it MTD specific. In fact I would suggest making it mandatory for all nvmem providers. That would be inline with 'interrupt-controller' and all the other properties used to indicate the capabilities of devices. Alban
Attachment:
pgpwkk90Fpr0k.pgp
Description: OpenPGP digital signature
