Hi Mark,
Am 28.02.2017 um 13:32 schrieb Mark Rutland:
> On Tue, Feb 28, 2017 at 07:35:21AM +0100, Andreas Färber wrote:
>> +/dts-v1/;
>> +
>> +#include "s500-guitar.dtsi"
>> +
>> +/ {
>> + compatible = "lemaker,guitar-bb-rev-b", "lemaker,guitar", "actions,s500";
>> + model = "LeMaker Guitar Base Board rev. B";
>> +
>> + aliases {
>> + serial3 = &uart3;
>> + };
>> +
>> + chosen {
>> + stdout-path = "serial3:115200n8";
>> + };
>> +};
>> +
>> +&uart3 {
>> + status = "okay";
>> +};
>
>> +#include "s500.dtsi"
>> +
>> +/ {
>> + compatible = "lemaker,guitar", "actions,s500";
>> +
>> + /delete-node/ memory;
>
> Eww. Is this just bodging around skeleton.dtsi?
I guess so: Working around its hardcoded name without unit address, not
finding a /rename-node/ to that effect.
>> +
>> + memory@0 {
>> + device_type = "memory";
>> + reg = <0x0 0x40000000>;
>> + };
>> +};
>
>> +#include "skeleton.dtsi"
>
> Please don't include skeleton.dtsi.
Wasn't aware that was permissible. I now see it has been updated with a
textual comment, which predates my past uses of skeleton.dtsi - for
other pending work such as FM4 and XMC4500 I only noticed it was moved
out of armv7m.dtsi so that dtc started spewing scary messages. ;)
A #warning might be a more effective way to make people aware of its
deprecation - but sadly we have users that predate #include:
$ git grep /include/ -- arch/arm/boot/dts/ | grep skeleton.dtsi | wc --lines
32
$ git grep /include/ -- arch/arm/boot/dts/ | grep skeleton64.dtsi | wc
--lines
0
$ git grep skeleton -- arch/arm/boot/dts/ | wc --lines
117
Might updating those 32 users be a suitable Outreachy project (CC'ed),
to then get the remaining 85 occurrences to be eliminated by their
maintainers, so that it doesn't get copied for new SoCs any more? :)
> Please add the relevant nodes and
> properties explciitly to your dts{i,} files.
Great, will do.
But this series has grown too large to resend just for such nits. Is
there a chance we can get initial patches queued on some arm-soc
for-next branch soonish? It seems -rc1 pulls were merged 5 days ago?
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
