On Mon, Feb 27, 2017 at 8:54 AM, Frank Rowand <frowand.list@xxxxxxxxx> wrote: > On 02/22/17 01:29, Sakari Ailus wrote: >> While holding a reference to a device_node it is allowed to put that node >> without holding devtree_lock spinlock. Move of_node_put() after releasing >> the spinlock. >> >> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > I would rather leave this code the way it is. > > The change is a micro-optimization that is not going to have any real > impact on performance. I have the same feelings. > > The change also makes the code less clear and readable. (Not > significantly, but very slightly). THe code in the current form > slightly emphasizes the balancing of gets and puts. I know that > this is nit picking, but so be it. > > Thus the change is on balance code churn. > > -Frank -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
