On 02/26/2017 07:24 PM, Jiancheng Xue wrote: > Hi Andreas, > > On 2017/2/26 9:32, Andreas Färber wrote: >> Am 22.02.2017 um 09:38 schrieb Jiancheng Xue: >>> Add bindings for HiSilicon hi3798cv200 SoC and Poplar Board. >>> >>> Signed-off-by: Jiancheng Xue <xuejiancheng@xxxxxxxxxxxxx> >>> --- >>> Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt >>> index f1c1e21..1fd3dd7 100644 >>> --- a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt >>> +++ b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt >>> @@ -4,6 +4,10 @@ Hi3660 SoC >>> Required root node properties: >>> - compatible = "hisilicon,hi3660"; >>> >>> +Hi3798cv200 Poplar Board >>> +Required root node properties: >>> + - compatible = "hisilicon,hi3798cv200-poplar", "hisilicon,hi3798cv200"; >> >> Please remember to CC previous reviewers. >> > Sorry for that. > >> This still looks wrong: Why is this not "hisilicon,poplar" if you choose >> against "tocoding,poplar"? > > I didn't think it was very important thing whether the compatbile string contained > a preceding SoC name or not. I just referred to the hikey board and some other > HiSilicon boards. I wanted to keep using the same rule with them. The way Jiancheng defined this was consistent with the pattern used for all other definitions of platforms found in this documentation file. Why make this one different? >> Is there a second Poplar board with a different SoC? > > I can't tell about this now. There is not. But there could be. In any case, I do accept your point that there's no need to encode the SoC identity in the board compatible string. But I don't think doing so causes harm. >> Even then it would be redundant with the second >> compatible string. I presume you're not arguing that the second compatible string should be eliminated; it seems your concern is only about including the SoC in the board's compatible string. Is that right? > The second compatilbe string can be removed here. Thanks. I don't think it should be. My position, for what it's worth, is that if a change is made to the compatible strings, it should be: compatible = "hisilicon,poplar", "hisilicon,hi3798cv200"; But I don't think it's necessary to make that change. Tocoding has no other DT presence in the kernel right now; it seems fine to tag the board with "hisilicon". -Alex > > Regards, > Jiancheng > >> Regards, >> Andreas >> >>> + >>> Hi4511 Board >>> Required root node properties: >>> - compatible = "hisilicon,hi3620-hi4511"; >> > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
