Hi Jacopo,
On Fri, Feb 24, 2017 at 4:50 PM, jacopo mondi <jacopo@xxxxxxxxxx> wrote:
> On 24/02/2017 16:29, Geert Uytterhoeven wrote:
>> On Fri, Feb 24, 2017 at 4:05 PM, Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
>> wrote:
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/iio/adc/max961x.txt
>>> @@ -0,0 +1,27 @@
>>> +* Maxim max9611/max9612 current sense amplifier with 12-bits ADC
>>> interface
>>> +
>>> +Maxim max9611/max9612 is an high-side current sense amplifier with
>>> integrated
>>> +12-bits ADC communicating over I2c bus.
>>> +The device node for this driver shall be a child of a I2c controller.
>>> +
>>> +Required properties
>>> + - compatible: Should be "maxim,max961x"
>>
>>
>> I'ts not a good idea to use wildcards in compatible values.
>> Ask yourself: is this valid for any (future) value of "x"?
>
> I suspect you already know the answer here :)
>
>> Hence please use "maxim,max9611" or "maxim,max9612".
>> The only difference between these two is a noninverting vs. inverting
>> input-to-output configuration. Does the driver need to care?
>
> No, not right now, as the inverting/non-inverting output is on the
> op-amp/comparator side, which is currently not supported by this driver.
>
> Instead of using one or the other, should we use both, as long as it does
> not makes any difference from driver perspective?
DT describes the hardware, not current software limitations.
So yes, we want both (in the bindings/drivers, not in the same *.dts file ;-).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
