On Tue, Feb 21, 2017 at 01:02:21PM +0200, Andy Shevchenko wrote: > On Tue, Feb 21, 2017 at 12:26 PM, Boris Brezillon > <boris.brezillon@xxxxxxxxxxxxxxxxxx> wrote: > > On Tue, 21 Feb 2017 12:03:45 +0200 > > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > >> 1. For example, > >> > >> #define ATMEL_NFC_CMD(pos, cmd) ((cmd) << > >> (((pos) * 8) + 2)) > > > > Well, I like to explicitly put parenthesis even when operator > > precedence guarantees the order of the calculation ('*' is preceding > > '+'). > > That's my point. I'm not a LISP programmer. > Personally I think it makes readability worse. +1. I find unnecessary parenthesis is an effective obfuscation technique. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html