Hi Naveen, On Thursday 19 of December 2013 11:37:02 Naveen Krishna Chatradhi wrote: > Exynos5420 SoC has per core thermal management unit. > 5 TMU channels 4 for CPUs and 5th for GPU. > > This patch adds the device tree nodes to the DT device list. > > Nodes carry the misplaced second base address and the second > clock to access the misplaced base address. [snip] > samsung,power-domain = <&gsc_pd>; > }; > + > + tmu_cpu0:tmu@10060000 { CodingStyle: Missing space after colon. + all the nodes below. Since it's just a minor fixup, I think you could just reply to this thread with corrected version of this single patch instead of respinning the whole series. Best regards, Tomasz > + compatible = "samsung,exynos5420-tmu"; > + reg = <0x10060000 0x100>; > + interrupts = <0 65 0>; > + clocks = <&clock 318>; > + clock-names = "tmu_apbif"; > + }; > + > + tmu_cpu1:tmu@10064000 { > + compatible = "samsung,exynos5420-tmu"; > + reg = <0x10064000 0x100>; > + interrupts = <0 183 0>; > + clocks = <&clock 318>; > + clock-names = "tmu_apbif"; > + }; > + > + tmu_cpu2:tmu@10068000 { > + compatible = "samsung,exynos5420-tmu-ext-triminfo"; > + reg = <0x10068000 0x100>, <0x1006c000 0x4>; > + interrupts = <0 184 0>; > + clocks = <&clock 318>, <&clock 318>; > + clock-names = "tmu_apbif", "tmu_triminfo_apbif"; > + }; > + > + tmu_cpu3:tmu@1006c000 { > + compatible = "samsung,exynos5420-tmu-ext-triminfo"; > + reg = <0x1006c000 0x100>, <0x100a0000 0x4>; > + interrupts = <0 185 0>; > + clocks = <&clock 318>, <&clock 319>; > + clock-names = "tmu_apbif", "tmu_triminfo_apbif"; > + }; > + > + tmu_gpu:tmu@100a0000 { > + compatible = "samsung,exynos5420-tmu-ext-triminfo"; > + reg = <0x100a0000 0x100>, <0x10068000 0x4>; > + interrupts = <0 215 0>; > + clocks = <&clock 319>, <&clock 318>; > + clock-names = "tmu_apbif", "tmu_triminfo_apbif"; > + }; > }; > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html