On 02/15/2017 09:14 AM, Alan Tull wrote: > On Wed, Feb 15, 2017 at 9:26 AM, Anatolij Gustschin <agust@xxxxxxx> wrote: >> Hi Joshua, >> >> On Tue, 24 Jan 2017 14:19:33 -0800 >> Joshua Clayton stillcompiling@xxxxxxxxx wrote: >> ... >>> +static int cyclonespi_write(struct fpga_manager *mgr, const char *buf, >>> + size_t count) >>> +{ >>> + struct cyclonespi_conf *conf = (struct cyclonespi_conf *)mgr->priv; >>> + const char *fw_data = buf; >>> + const char *fw_data_end = fw_data + count; >>> + >>> + while (fw_data < fw_data_end) { >>> + int ret; >>> + size_t stride = min(fw_data_end - fw_data, SZ_4K); >>> + >>> + rev_buf(fw_data, stride); >> Can we make rev_buf() optional here? I've tested this driver with >> Stratix-V FPGA using orion_spi driver. It works without swapping >> the data. Thanks for testing! I'd be happy to make it an optional feature, rather than integral. > I replied earlier, but something in my email settings bounced. > > The way to make it optional is to add a bit to the flags of the > fpga_image_info struct. > > Alan OK. > >> Thanks, >> Anatolij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html