Hello Mark, On 02/14/2017 06:16 PM, Mark Brown wrote: > On Mon, Feb 13, 2017 at 05:38:26PM +0100, Arnaud Pouliquen wrote: >> From: olivier moysan <olivier.moysan@xxxxxx> >> >> Add copy support in pcm damengine operations. As example, this >> allows to: - process data before rendering (IEC status >> insertion), - process captured sample ( sample mask and shift). > > dmaengine with copy... so not DMA at all? I'm a bit confused > about why we're extending the dmaengine code to have a copy > operation rather than just writing driver code. > For DFSDM we need to re-arrange samples after DMA transfer, before sending them to application. For this, a copy ops(called in snd_pcm_lib_read_transfer) alreday exists in snd_pcm_ops struct. This ops is not available at soc dma engine level, so at ASoC driver level. Aim of this patch is to expose the copy in driver. DMA is still used, copy ops just allows to handle the copy_to_user in driver. Advantage of this add-on is that we still able to take benefice of the generic DMA in DFSDM driver. Now if you estimate that it is too stm32 SOC specific, the other solution is to handle directly the PCM platform device in DFSDM driver. Regards Arnaud -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
