Re: [PATCH 1/8] v4l: flash led class: Use fwnode_handle instead of device_node in init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Sakari,

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.10-rc8 next-20170213]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sakari-Ailus/v4l-flash-led-class-Use-fwnode_handle-instead-of-device_node-in-init/20170213-213642
base:   git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-x002-201707 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   drivers/leds/leds-aat1290.c: In function 'aat1290_led_probe':
>> drivers/leds/leds-aat1290.c:506:41: error: implicit declaration of function 'of_fwnode_handle' [-Werror=implicit-function-declaration]
     led->v4l2_flash = v4l2_flash_init(dev, of_fwnode_handle(sub_node),
                                            ^~~~~~~~~~~~~~~~
>> drivers/leds/leds-aat1290.c:506:41: warning: passing argument 2 of 'v4l2_flash_init' makes pointer from integer without a cast [-Wint-conversion]
   In file included from drivers/leds/leds-aat1290.c:23:0:
   include/media/v4l2-flash-led-class.h:140:34: note: expected 'struct device_node *' but argument is of type 'int'
    static inline struct v4l2_flash *v4l2_flash_init(
                                     ^~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/of_fwnode_handle +506 drivers/leds/leds-aat1290.c

   500		if (ret < 0)
   501			goto err_flash_register;
   502	
   503		aat1290_init_v4l2_flash_config(led, &led_cfg, &v4l2_sd_cfg);
   504	
   505		/* Create V4L2 Flash subdev. */
 > 506		led->v4l2_flash = v4l2_flash_init(dev, of_fwnode_handle(sub_node),
   507						  fled_cdev, NULL, &v4l2_flash_ops,
   508						  &v4l2_sd_cfg);
   509		if (IS_ERR(led->v4l2_flash)) {

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux