On Thu, Feb 09, 2017 at 04:46:45PM +0000, Mark Brown wrote: > On Thu, Feb 09, 2017 at 11:12:57AM +0800, Baoyou Xie wrote: > > > - - compatible : Must be "zte,zx296702-i2s" > > + - compatible : Must be one of: > > + "zte,zx296718-i2s", "zte,zx296702-i2s" > > + "zte,zx296702-i2s" > > You've added the new compatible twice here? It's indeed a bit confusing. Might be better if we add a couple of bullet like below. - compatible : Must be one of: - "zte,zx296718-i2s", "zte,zx296702-i2s"; - "zte,zx296702-i2s"; In this case, it's more easier for readers to understand that the first one is for I2S device on SoC ZX296718, while it's compatible with the I2S on ZX296702. Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html