On Mon, Feb 13, 2017 at 5:16 PM, Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote: > Hi, > > On Sat, Feb 11, 2017 at 07:43:59PM +0200, Priit Laes wrote: >> Added basic display pipeline consisting of tcon, display backend and >> frontend blocks. >> >> Signed-off-by: Priit Laes <plaes@xxxxxxxxx> >> --- >> arch/arm/boot/dts/sun4i-a10.dtsi | 104 +++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 104 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi >> index ba20b48..70991c9 100644 >> --- a/arch/arm/boot/dts/sun4i-a10.dtsi >> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi >> @@ -779,6 +779,45 @@ >> #size-cells = <0>; >> }; >> >> + tcon0: lcd-controller@1c0c000 { >> + compatible = "allwinner,sun5i-a13-tcon"; > > There's a few bits here and there that need to be setup differently in > A10, so you cannot reuse that compatible (same thing for the other). > > Also, I'd really like to have all the blocks listed here, and not only > the first pipeline. Ideally, on the A10, the two pipelines should be > enabled too. The display pipeline driver has to be fixed before that can happen though. And I haven't started to work on what I proposed yet. Though if someone wants to take over I can forward any design plans I have. ChenYu > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html