On Sat, Feb 11, 2017 at 07:44:02PM +0200, Priit Laes wrote: > Depending on the output type, we have to enable/disable some > bits conditionally. > > Signed-off-by: Priit Laes <plaes@xxxxxxxxx> > --- > drivers/gpu/drm/sun4i/sun4i_rgb.c | 2 +- > drivers/gpu/drm/sun4i/sun4i_tcon.c | 3 ++- > drivers/gpu/drm/sun4i/sun4i_tcon.h | 3 ++- > 3 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/sun4i/sun4i_rgb.c b/drivers/gpu/drm/sun4i/sun4i_rgb.c > index f5e86fe..3d4eb05 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_rgb.c > +++ b/drivers/gpu/drm/sun4i/sun4i_rgb.c > @@ -179,7 +179,7 @@ static void sun4i_rgb_encoder_mode_set(struct drm_encoder *encoder, > struct sun4i_drv *drv = rgb->drv; > struct sun4i_tcon *tcon = drv->tcon; > > - sun4i_tcon0_mode_set(tcon, mode); > + sun4i_tcon0_mode_set(tcon, mode, DRM_MODE_ENCODER_DAC); This is not the proper encoder type. You can just use encoder_type in drm_encoder. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature