On 2017-02-09 00:32, Florian Fainelli wrote:
On 02/08/2017 03:30 PM, Rafał Miłecki wrote:
From: Rafał Miłecki <rafal@xxxxxxxxxx>
This reverts commit d7bc1a7d41bf ("phy: Add USB3 PHY support for
Broadcom NSP SoC") as we already have driver for this PHY (shared by
NS
and NSP). It was added in commit e5666281d9ea ("phy: bcm-ns-usb3: new
driver for USB 3.0 PHY on Northstar").
Instead of adding separated driver & duplicating code we should work
on
improving existing (old) one. Thanks to work done by Broadcom we know
there is MDIO bus we weren't aware of & we know register names which
makes initialization more clear. This is very valuable info and we
should work on using it in existing driver afterwards.
Should not we first extend the old driver to support NSP and then
revert
d7bc1a7d41bf ("phy: Add USB3 PHY support for Broadcom NSP SoC")?
Sounds like a weird / dirty development method to me: adding duplicated
code
first then working on cleaning it. Unless you mean drivers/staging/.
We also should never drop support for supported DT bindings, so I really
think
it's the cleanest to revert it now.
I think Jon was also OK with this solution.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
