Re: [PATCH] ARM: dts: imx6q-cm-fx6: add analog audio support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Fabio,

thanks for the review!

On 02/07/2017 11:39 PM, Fabio Estevam wrote:
On Tue, Feb 7, 2017 at 6:31 PM,  <christopher.spinrath@xxxxxxxxxxxxxx> wrote:

+&audmux {
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_audmux>;
+       status = "okay";
+
+       ssi2 {
+               fsl,audmux-port = <1>;
+               fsl,port-config = <
+                       (IMX_AUDMUX_V2_PTCR_RCLKDIR |
+                       IMX_AUDMUX_V2_PTCR_RCSEL(3 | 0x8) |
+                       IMX_AUDMUX_V2_PTCR_TCLKDIR |
+                       IMX_AUDMUX_V2_PTCR_TCSEL(3))
+                       IMX_AUDMUX_V2_PDCR_RXDSEL(3)
+               >;
+       };
+
+       pins5 {

Just one minor nit: maybe pins4 since you are using AUD4 pins. Or
maybe 'audmux4' as pins4 is too vague ?

Sounds good. Actually, CompuLab uses the term audmux4 themselves in the block diagram of the board.

Cheers,
Christopher

Reviewed-by: Fabio Estevam <fabio.estevam@xxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux