On Monday 30 January 2017 03:32 PM, Bartosz Golaszewski wrote: > + /* > + * The second clock used by ahci-da850 is the external REFCLK. If we > + * didn't get it from ahci_platform_get_resources(), let's try to > + * specify the con_id in clk_get(). > + */ > + if (!hpriv->clks[1]) { > + clk = clk_get(dev, "refclk"); > + if (IS_ERR(clk)) { > + dev_err(dev, "unable to obtain the reference clock"); > + return -ENODEV; > + } else { > + hpriv->clks[1] = clk; > + } This results in a checkpatch warning about the unneeded else. I fixed this locally to look like: + */ + if (!hpriv->clks[1]) { + clk = clk_get(dev, "refclk"); + if (IS_ERR(clk)) { + dev_err(dev, "unable to obtain the reference clock"); + return -ENODEV; + } + + hpriv->clks[1] = clk; + } Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html