Hello Jonathan, Thanks for the reviews, i will integrate your comment in next version. On 01/29/2017 01:15 PM, Jonathan Cameron wrote: > On 23/01/17 16:32, Arnaud Pouliquen wrote: >> Add driver to handle Sigma Delta ADC conversion for ADC >> connected to DFSDM IP. >> >> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@xxxxxx> > Various comments inline. Again mostly reading this to grasp how the whole > lot fits together. > > At the moment, other than some new ABI, this is a fairly simple sysfs or in > kernel polled ADC driver. The hardware seems to support a whole lot more > but fair enough to present this as a starting point! Yes, from IIO point of view, should increase driver features in future to integrate buffer, scan mode, triggers... Or perhaps i will need to introduce some of these concepts to handle ASoC requirement in IIO... FYI, DFSDM also offers some features like Analog watchdog, short circuit and SPI/manchester bus clock absence detection detection...:) Regards Arnaud -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html