Sent from Anson's iPhone > 在 2013年12月17日,21:23,"Mark Brown" <broonie@xxxxxxxxxx> 写道: > >> On Tue, Dec 17, 2013 at 05:08:22PM -0500, Anson Huang wrote: >> >> if (new_freq > old_freq) { >> + if (regulator_is_enabled(pu_reg)) { >> + ret = regulator_set_voltage_tol(pu_reg, imx6_soc_volt[index], 0); > > As I pointed out while reviewing the regulator driver this is racy, > nothing stops the regulator state being changed after you read it and if > you skip setting the voltage then when something comes along and enables > the regulator later it will be enabled with a possibly incorrect > voltage. yes, you are correct, I will remove this PU status check in V3 patch. Anson?韬{.n?????%??檩??w?{.n????z谵{???塄}?财??j:+v??????2??璀??摺?囤??z夸z罐?+?????w棹f