Hi Andrew, On Mo, 2017-01-23 at 19:18 +0100, Andrew Lunn wrote: > On Mon, Jan 23, 2017 at 03:22:06PM +0100, Jan Luebbe wrote: > > The Marvell MVNETA Ethernet controller supports a 2.5 Gbps SGMII mode > > called DRSGMII. > > > > This patch adds a corresponding phy-mode string 'drsgmii' and parses it > > from DT. The MVNETA then configures the SERDES protocol value > > accordingly. > > So this sets the PHY to 2.5Gbps. What about the MAC? Currently, > mvneta_adjust_link() knows about SPEED_1000 and SPEED_100. Does it now > need to know about SPEED_2500? mvneta_ethtool_set_link_ksettings()? It works without any other changes. ;) Initially I looked at adding a SPEED_2500, but I wasn't sure which code would need to handle the new value. Would the path from the ethtool ioctl to the driver be enough (mvneta_ethtool_set_link_ksettings() as you said)? Regards, Jan -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
