On Tue, 17 Dec 2013, Tero Kristo wrote: > On 12/17/2013 10:14 AM, Paul Walmsley wrote: > > On Tue, 26 Nov 2013, Tero Kristo wrote: > > > > > ti_dt_clk_init_provider() can now be used to initialize the contents of > > > a single clock IP block. This parses all the clocks under the IP block > > > and calls the corresponding init function for them. > > > > > > This patch also introduces a helper function for the TI clock drivers > > > to get register info from DT and append the master IP info to this. > > > > > > Signed-off-by: Tero Kristo <t-kristo@xxxxxx> > > > > ... > > > > > diff --git a/drivers/clk/ti/clk.c b/drivers/clk/ti/clk.c > > > index ef1a7cd..63f85e9 100644 > > > --- a/drivers/clk/ti/clk.c > > > +++ b/drivers/clk/ti/clk.c > > > @@ -19,10 +19,15 @@ > > > #include <linux/clkdev.h> > > > #include <linux/clk/ti.h> > > > #include <linux/of.h> > > > +#include <linux/of_address.h> > > > +#include <linux/list.h> > > > > > > #undef pr_fmt > > > #define pr_fmt(fmt) "%s: " fmt, __func__ > > > > > > +extern struct of_device_id __clk_of_table[]; > > > > This results in a checkpatch.pl warning: > > > > WARNING: externs should be avoided in .c files > > #33: FILE: drivers/clk/ti/clk.c:28: > > +extern struct of_device_id __clk_of_table[]; > > This extern is only needed from this single file, and this code is duplicated > from drivers/clk/clk.c. So the right thing to do here is to move it into a separate header file that both drivers/clk/clk.c and drivers/clk/ti/clk.c either already #include, or can add a new #include for. - Paul -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
