Daniel, thanks for reviewing patches! > 23 янв. 2017 г., в 19:26, Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> написал(а): > > On Tue, Nov 29, 2016 at 07:14:49PM +0300, Alexander Kochetkov wrote: >> The patch move ce field out of struct bc_timer into struct >> rk_clock_event_device and rename struct bc_timer to struct rk_timer. > > Why ? Single rockchip timer can be either broadcast timer/clockevent (current implementation) or clocksource (the one I’ve implemented in series). Both implementations based on low level timer routines (rk_timer_disable, rk_timer_enable, rk_timer_update_counter, rk_timer_counter_read and so on). Both implementations use timers in different modes (interrupts vs free running). In order to distinguish this concepts I tried to split low level timer routines from bc_timer. Otherwise I can place all needed clocksource filelds into 'struct bc_timer’ and rename 'struct bc_timer’ into 'struct rk_timer’. If this is more clear solution I can rewrite patches. Alexander.-- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html