RE: [PATCH v2 2/3] ARM: dts: r7s72100: add ostm to device tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hello Geert,

On Sunday, January 22, 2017, Geert Uytterhoeven wrote:
> > diff --git a/arch/arm/boot/dts/r7s72100.dtsi
> > b/arch/arm/boot/dts/r7s72100.dtsi index d5946df..47b2165 100644
> > --- a/arch/arm/boot/dts/r7s72100.dtsi
> > +++ b/arch/arm/boot/dts/r7s72100.dtsi
> > @@ -505,4 +505,20 @@
> >                 cap-sdio-irq;
> >                 status = "disabled";
> >         };
> > +
> > +       ostm0: ostm@fcfec000 {
> > +               compatible = "renesas,r7s72100-ostm", "renesas,ostm";
> > +               reg = <0xfcfec000 0x30>;
> > +               interrupts = <GIC_SPI 102 IRQ_TYPE_EDGE_RISING>;
> > +               clocks = <&mstp5_clks R7S72100_CLK_OSTM0>;
> 
> Missing power-domains property:
> 
>         power-domains = <&cpg_clocks>;
> 
> > +               status = "disabled";
> > +       };
> > +
> > +       ostm1: ostm@fcfec400 {
> > +               compatible = "renesas,r7s72100-ostm", "renesas,ostm";
> > +               reg = <0xfcfec400 0x30>;
> > +               interrupts = <GIC_SPI 103 IRQ_TYPE_EDGE_RISING>;
> > +               clocks = <&mstp5_clks R7S72100_CLK_OSTM1>;
> 
> Likewise.

OK. Thank you.


> BTW, they're also missing for the last added device nodes (MMC and SDHI).

OK, I will submit patches for them as well.

Thank you for the review.

Chris

��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux