On Fri, Jan 20, 2017 at 11:21:27AM +0100, Rafael J. Wysocki wrote: > On Fri, Jan 20, 2017 at 8:52 AM, Peter Chen <hzpeterchen@xxxxxxxxx> wrote: > > On Tue, Jan 10, 2017 at 03:02:41PM +0800, Peter Chen wrote: > >> On Sat, Jan 07, 2017 at 10:54:56AM +0200, Krzysztof Kozlowski wrote: > >> > On Thu, Jan 05, 2017 at 02:01:53PM +0800, Peter Chen wrote: > >> > > We have an well-known problem that the device needs to do some power > >> > > sequence before it can be recognized by related host, the typical > >> > > example like hard-wired mmc devices and usb devices. > >> > > > >> > > This power sequence is hard to be described at device tree and handled by > >> > > related host driver, so we have created a common power sequence > >> > > library to cover this requirement. The core code has supplied > >> > > some common helpers for host driver, and individual power sequence > >> > > libraries handle kinds of power sequence for devices. The pwrseq > >> > > librares always need to allocate extra instance for compatible > >> > > string match. > >> > > > >> > > pwrseq_generic is intended for general purpose of power sequence, which > >> > > handles gpios and clocks currently, and can cover other controls in > >> > > future. The host driver just needs to call of_pwrseq_on/of_pwrseq_off > >> > > if only one power sequence is needed, else call of_pwrseq_on_list > >> > > /of_pwrseq_off_list instead (eg, USB hub driver). > >> > > > >> > > For new power sequence library, it can add its compatible string > >> > > to pwrseq_of_match_table, then the pwrseq core will match it with > >> > > DT's, and choose this library at runtime. > >> > > > >> > > Signed-off-by: Peter Chen <peter.chen@xxxxxxx> > >> > > Tested-by: Maciej S. Szmigiero <mail@xxxxxxxxxxxxxxxxxxxxx> > >> > > Tested-by Joshua Clayton <stillcompiling@xxxxxxxxx> > >> > > Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > >> > > Tested-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > >> > > >> > Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > >> > Tested on Odroid U3 (reset sequence for LAN9730): > >> > Tested-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > >> > > >> > >> A nice ping... > >> > > > > Rafael, would you please review it? This series was discussed about > > half a year, and many people need it, I hope it can be in v4.11-rc1, > > thanks. > > I'm travelling now > (http://marc.info/?l=linux-pm&m=148410629024194&w=2) and (as stated in > this message) I'll get to the patches when I'm back home. > > There is a good chance for your code to go into 4.11-rc1 if the review > comments so far have been addressed. > Thanks, Rafael. I think I have addressed all your comments. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
