Hi Rob,
thanks for reviewing this!
On Sat, Jan 21, 2017 at 9:56 PM, Rob Herring <robh@xxxxxxxxxx> wrote:
> On Thu, Jan 19, 2017 at 03:58:19PM +0100, Martin Blumenstingl wrote:
>> This adds the devicetree binding documentation for the SAR ADC found in
>> Amlogic Meson SoCs.
>> Currently only the GXBB, GXL and GXM SoCs are supported.
>>
>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
>> Tested-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
>> ---
>> .../bindings/iio/adc/amlogic,meson-saradc.txt | 31 ++++++++++++++++++++++
>> 1 file changed, 31 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.txt
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.txt b/Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.txt
>> new file mode 100644
>> index 000000000000..9a0bec7afc63
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.txt
>> @@ -0,0 +1,31 @@
>> +* Amlogic Meson SAR (Successive Approximation Register) A/D converter
>> +
>> +Required properties:
>> +- compatible: depending on the SoC this should be one of:
>> + - "amlogic,meson-gxbb-saradc" for GXBB
>> + - "amlogic,meson-gxl-saradc" for GXL and GXM
>
> GXL and GXM should probably be 2 compatibles.
Amlogic's ADC driver does not differentiate between GXL and GXM
(because both SoCs are identical except the CPU and GPU cores).
I can still introduce a separate binding for GXM if you want (better
safe than sorry and takes less than 5 minutes) - just let me know
>> + along with the generic "amlogic,meson-saradc"
>> +- reg: the physical base address and length of the registers
>> +- clocks: phandle and clock identifier (see clock-names)
>> +- clock-names: mandatory clocks:
>> + - "clkin" for the reference clock (typically XTAL)
>> + - "core" for the SAR ADC core clock
>> + optional clocks:
>> + - "sana" for the analog clock
>> + - "adc_clk" for the ADC (sampling) clock
>> + - "adc_sel" for the ADC (sampling) clock mux
>> +- vref-supply: the regulator supply for the ADC reference voltage
>> +- #io-channel-cells: must be 1, see ../iio-bindings.txt
>> +
>> +Example:
>> + saradc: adc@8680 {
>> + compatible = "amlogic,meson-gxl-saradc", "amlogic,meson-saradc";
>> + #io-channel-cells = <1>;
>> + reg = <0x0 0x8680 0x0 0x34>;
>> + clocks = <&xtal>,
>> + <&clkc CLKID_SAR_ADC>,
>> + <&clkc CLKID_SANA>,
>> + <&clkc CLKID_SAR_ADC_CLK>,
>> + <&clkc CLKID_SAR_ADC_SEL>;
>> + clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
>> + };
>> --
>> 2.11.0
>>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
