Hi Krzysztof, On Wednesday 18 January 2017 08:31 PM, Krzysztof Kozlowski wrote: > On Wed, Jan 18, 2017 at 11:12:21AM +0530, Pankaj Dubey wrote: >> Usage of DTS macros instead of hard-coded numbers makes code easier to >> read. One does not have to remember which value means pull-up/down or >> specific driver strength. >> >> Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> >> --- >> arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 4 +- >> arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 302 ++++++++++++------------ >> 2 files changed, 154 insertions(+), 152 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts >> index c528dd5..1b2db9f0 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts >> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts >> @@ -328,8 +328,8 @@ >> &pinctrl_alive { >> pmic_irq: pmic-irq { >> samsung,pins = "gpa0-2"; >> - samsung,pin-pud = <3>; >> - samsung,pin-drv = <3>; >> + samsung,pin-pud = <EXYNOS_PIN_PULL_UP>; >> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>; >> }; >> }; > > This is not equal (value 3 => 1). If the change was intended, please do > in separate patch. > This was not an intended change. It should be EXYNOS4_PIN_DRV_LV4, I will submit another set after fixing this. Thanks, Pankaj Dubey > Rest looks fine. > > Best regards, > Krzysztof > > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html