Hi Rob > This looks okay, but I think we need to be improving the graph api at > a higher level. Each user seems to be doing too much open coding of > walking of the graph. The user typically just wants the remote node > parent of a given port and endpoint number. Why does the user walk the > graph to find the endpoint node, then parse remote-endpoint, then walk > up parents. We have lots of other graph users and you didn't need to > update them which means they are already using helpers. Maybe the > drivers here need to be fixed. omapfb in particular looks like it > duplicates a bunch of helpers we already have, but maybe we're close > to removing that driver. Does your "we need to be improving the graph api at a higher level" mean I need to re-work this patch ? Or someone (?) will improve OF-graph, and I need to wait it ? More direct words, will this patch be accepted ?? You know I'm working for OF-graph base HDMI sound now, and actually, I have some OF-graph new API which is useful for OF-graph HDMI sound support. (I don't like open coding, I want to have useful/understandable common api) This get_remote_endpoint is one of them, and was ready for posting. So, I will post other OF-graph base patches if OF-graph HDMI sound was ready. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html