On 20/01/17 12:19, Sebastian Hesselbarth wrote: > On 19.01.2017 22:12, Chris Packham wrote: >> On 14/01/17 20:50, Chris Packham wrote: >>> On 13/01/17 22:54, Sebastian Hesselbarth wrote: >>>> On 13.01.2017 10:12, Chris Packham wrote: >>>>> From: Kalyan Kinthada <kalyan.kinthada@xxxxxxxxxxxxxxxxxxx> >>>>> >>>>> This pinctrl driver supports the 98DX3236, 98DX3336 and 98DX4251 SoCs >>>>> from Marvell. >>>>> >>>>> Signed-off-by: Kalyan Kinthada <kalyan.kinthada@xxxxxxxxxxxxxxxxxxx> >>>>> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> >>>>> Acked-by: Rob Herring <robh@xxxxxxxxxx> >>>>> Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx> >>>>> --- >>>>> >>>>> Notes: >>>>> Changes in v2: >>>>> - include sdio support for the 98DX4251 >>>>> Changes in v3: >>>>> - None >>>>> Changes in v4: >>>>> - Correct some discrepencies between binding and driver. >>>> >>>> Well, unfortunately I still see differences between the "gpio" in >>>> the binding and "gpo" in the driver. >>>> >>>> Please go back to that list I sent you yesterday and fix them all. >>>> >>> >>> I think you may have missed my initial reply [1]. Or I have missed your >>> response to it. Long story short "gpo" is intentional because some of >>> those pins can't be used as inputs. But if you still want me to change >>> it I will. >>> >>> [1] - https://lkml.org/lkml/2017/1/12/117 >>> >> >> Did you get a chance to consider this. Do you still want me to change >> gpo -> gpio given the information above? > > Chris, > > sorry if I wasn't clear enough. I don't want you to change every gpo > into gpio. All I was referring to is the _difference_ between driver > implementation and device tree binding - and soley resolve that. > > So, for the gpo's I see that the binding doc still says "gpio" for the > available functions where the driver expects "gpo". > > e.g. the binding has this: > > mpp6 6 gpio, sd0(clk), dev(a2) > > if you change it to > > mpp6 6 gpo, sd0(clk), dev(a2) > > both binding and driver are the same, right? > > I do understand that the hardware is gp-output only and you correctly > reflected that in the pinctrl driver - but the binding doc does not > reflect that for those mpps in the list. > Ah OK thanks for clearing up my confusion. I'll make sure the binding and the driver are consistent when I submit v5 (probably next week). -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
