2017-01-18 19:28 GMT+01:00 Tejun Heo <tj@xxxxxxxxxx>: > Hello, Bartosz. > > On Wed, Jan 18, 2017 at 02:19:57PM +0100, Bartosz Golaszewski wrote: >> We need a way to retrieve the information about the online state of >> the link in the ahci-da850 driver. >> >> Create a new function: ahci_do_hardreset() which is called from >> ahci_hardreset() for backwards compatibility, but has an additional >> argument: 'online' - which can be used to check if the link is online >> after this function returns. > > Please just add @online to ahci_hardreset() and update the callers. > Other than that, the sata changes look good to me. > Are you sure? There are 23 places in drivers/ata/ where the .hardreset callback is assigned. I'd prefer not to change the drivers I can't test. Besides all other **reset callbacks take three arguments - should we really only change one of them for a single driver's needs? Thanks, Bartosz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
