On 01/14/17 at 11:14am, Dmitry Torokhov wrote: > > + > > +static const struct of_device_id zet6223_of_match[] = { > > + { .compatible = "zeitec", "zet6223" }, > > The compatible should be "zeitec,zet6223", what you have here is > equivalent of: > > { .compatible = "zeitec", .data = "zet6223" }, Ah that was silly, thanks :) > I also have been looking at you previosu submission and had some draft > changes. I reconciled them in the patch below, if it still works for you > then I'll fold everything together and apply. Please let me know. I'll find some time to test the patch below, I've one small suggestion to the patch below. > + ts->fingernum = buf[15] & 0x7F; > + if (ts->fingernum > ZET6223_MAX_FINGERS) { > + dev_warn(&ts->client->dev, > + "touchpanel reports %d fingers, limiting to %d\n", > + ts->fingernum, ZET6223_MAX_FINGERS); > + ts->fingernum = 16; Maybe use ZET6223_MAX_FINGERS? -- Jelle van der Waa -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html