Hi Chris, > + struct clk *clk2; I'd vote for 'clk_cd' since we are explicitly requesting that clock for it. > + ret = clk_prepare_enable(priv->clk2); > + if (ret < 0) > + return ret; You need to disable clk when failing. Regards, Wolfram -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html