On Tue, Dec 10, 2013 at 10:04:27PM +0000, Antti Miettinen wrote: > Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> writes: > > I do not think we should think about how the kernel uses this data. > > We should strive to make DT data representative of HW C-states and > > that's very complex, as you mentioned (it depends at what granularity > > we want these bits of info). > > > > When we are happy with the bindings we can then code the kernel accordingly. > > > > Please let me know how you would like to have these bindings extended > > (eg adding operating points), getting feedback is the main reason why > > I posted them in the first place. > > Hmm.. I'd like to challenge that a bit. I guess we are not defining DT > bindings just for the joy of modelling the hardware? We should care > whether kernel needs the data and have some idea of how the data will be > used. I agree all I am saying is that DT bindings must not contain anything Linux kernel specific, ie adding parameters that are purely SW concepts (eg menu governor target_residency). > As you say, modelling C state details is not trivial. It might be > possible to construct an approximate formula for e.g. entry/exit latency > that takes CPU frequency, memory frequency and PMIC ramp rates as > input. Also, in principle we could estimate power based on clocks, > voltages, temperature etc. As we probably do not want to put function > definitions to DT, the DT would contain e.g. coefficients for functions > that would need to be platform neutral. I do not think we should model anything in DT, we should define what a C-state entry/exit implies in HW. The kernel can model the behaviour depending on the parameters provided by the DT data. > Is this what you'd like to see? There has been some research in > estimating power without actually measuring it, e.g. the google > powertutor people have written some papers about this. The latencies > could be measured to some extend with instrumentation in the kernel and > the measurement results could be used to tune some parameters. > > Or would you rather have tables, which specify latencies and power > levels and the tables would be indexed with frequencies and voltages? The latter. I did not add operating points info in v1 because I thought it might have been too much, but I think it is something we should consider for the final version. > Anyway, I would really like to see the option of having the state choice > in the driver. One possible way to achieve this would be to allow for > the driver to export an optional "choose" method. If that exists the > governor would offload the decision to the driver. That's a separate discussion. CPUidle backends can already demote C-states depending on HW states (pending IRQs, state of caches). This also has loads of dependencies (what piece of code is in charge of making the final decision ? Kernel ? FW (ie PSCI) ?). I think as I mentioned that the state choice discussion is a parallel track altogether. Let's define what bits of info are required in the DT first, with an eye on how the kernel can make use of them, then we can focus on changing the kernel (actually idle interfaces changes are already under way owing to scheduler discussions) to make best usage of them. Thanks, Lorenzo -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
