Re: [PATCH 1/5] ARM: OMAP2+: omap_hwmod: Add support for earlycon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Tuesday 17 January 2017 04:17 PM, Mark Rutland wrote:
> On Tue, Jan 17, 2017 at 09:33:32AM +0530, Lokesh Vutla wrote:
>> Hwmod core tries to reset and idles each IP that is registered with hwmod.
>> In case of earlycon, that specific uart IP cannot be reset or keep it in
>> idle state else earlycon hangs once hwmod resets that uart IP. So add support
>> to not reset uart that is being used as earlycon only if CONFIG_SERIAL_EARLYCON
>> is enabled.
> 
>> +	np = of_find_node_by_path("/chosen");
>> +	if (!np)
>> +		np = of_find_node_by_path("/chosen@0");
> 
> I think you can drop the second case here. There shouldn't be an "@0" on
> a chosen node; core code handles that only to cater for some legacy
> (PPC?) DTBs, and I don't beleive it's necessary for OMAP.

Right. Ill repost this series by dropping this case.

Thanks and regards,
Lokesh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux