Hi Wolfram and Geert,
On Monday, January 16, 2017, Wolfram Sang:
> > > and then in the code do:
> > >
> > > struct *cd_clk;
> > > cd_clk = devm_clk_get(&pdev->dev, "cd");
> > > if (cd_clk) {
> > > clk_prepare_enable(cd_clk);
> > > }
> > >
> > > (this simple 1-line fix patch is getting a lot more complicated)
> >
> > Disclaimer: I don't know how/if the SDHI core manages clocks, and may
> > interfere. Adding Wolfram.
>
> Thanks for the heads up.
>
> We have special callbacks for en-/disabling clocks:
> sh_mobile_sdhi_clk_enable() and sh_mobile_sdhi_clk_disable().
>
> I think those functions should get the above if-blocks (without curly
> braces) to ensure we always have consistent 00 or 11 settings.
Well....
I was going to try and cheat and in the probe, enable both the core
and card-detect clocks, but, not save the card-detect clock pointer.
Basically, once it is turned on, it is never turned off (since it was intended
to be used for low power operation anyway).
The reason is that would then keep me from having to modify the existing
functions sh_mobile_sdhi_clk_enable/disable.
Is anyone going to have an issue if I turn the card-detect clock on but never
turn it off???? That was the patch that I was going to test out and submit.
Chris
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
