Hi, Arnd Bergmann <arnd@xxxxxxxx> writes: > On Friday, January 6, 2017 12:29:12 PM CET Raviteja Garimella wrote: >> Hi Arnd, >> >> On Fri, Jan 6, 2017 at 3:33 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote: >> > On Thursday, January 5, 2017 1:53:16 PM CET Raviteja Garimella wrote: >> >> The UDC is based on Synopsys Designware core USB (2.0) Device controller >> >> IP. >> > ... >> >> This is a request for comments from maintainers/others regarding approach >> >> on whether to have 2 different drivers (one each for AMD and Broadcom) >> >> with a common library (3 files in total), or have a single driver like >> >> it's done in this patch and have the driver filename changed to some >> >> common name based on ther underlying IP, like snps_udc.c. >> > >> > I have not looked at the code at all, so sorry for my ignorance, but >> > isn't the IP block you describe the one that drivers/usb/dwc2/ is for? >> > Could you add support for the Broadcom hardware there instead? >> >> The current driver I submitted is for a different Synopsys IP (USB >> Device Controller IP, >> not the HS OTG). It's confirmed by John Youn (from Synopsys) earlier. >> > > Ok, sounds fine the. I'd suggest taking the current driver than and > splitting out the pci_driver front-end into a separate module that > calls exported symbols of the main driver, with the new platform > driver in a third file that also calls the same exported symbols. right, that's the best idea. -- balbi
Attachment:
signature.asc
Description: PGP signature
