On 2017-01-16 04:11, Phil Reid wrote: > Unfortunately some hardware device will assert their irq line immediately > on power on and provide no mechanism to mask the irq. As the i2c muxes > provide no method to mask irq line this provides a work around by keeping > the parent irq masked until enough device drivers have loaded to service > all pending interrupts. > > For example the the ltc1760 assert its SMBALERT irq immediately on power > on. With two ltc1760 attached to bus 0 & 1 on a pca954x mux when the first > device is registered irq are enabled and fire continuously as the second > device driver has not yet loaded. Setting this parameter to 0x3 while > delay the irq being enabled until both devices are ready. > > Acked-by: Peter Rosin <peda@xxxxxxxxxx> > Acked-by: Rob Herring <robh@xxxxxxxxxx> Hmm, I see that this is already acked by some people :-) ... ... but. I just thought a bit more about it and going forward it might make sense to make this not a bitmask that only support 0 or 1 irq clients for each mux segment, and instead make it one u32 for each segment. Then the binding would extend to also cover cases where several i2c clients register for interrupts and the shared interrupt needs to be masked until the last client is registered. Or is that idea over-engineered? I'd be satisfied if the implementation simply mapped the u32 array to a bitmask, as long as it failed noisily when finding anything bigger than 1 in the array. Cheers, peda > Signed-off-by: Phil Reid <preid@xxxxxxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt > index aa09704..6de1e8e 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt > @@ -19,6 +19,8 @@ Optional Properties: > - i2c-mux-idle-disconnect: Boolean; if defined, forces mux to disconnect all > children in idle state. This is necessary for example, if there are several > multiplexers on the bus and the devices behind them use same I2C addresses. > + - nxp,irq-mask-enable: BitMask; Defines a mask for which irq lines need to be > + unmasked before the parent irq line in enabled. > - interrupt-parent: Phandle for the interrupt controller that services > interrupts for this device. > - interrupts: Interrupt mapping for IRQ. > @@ -36,6 +38,7 @@ Example: > #size-cells = <0>; > reg = <0x74>; > > + nxp,irq-mask-enable = <0x3>; > interrupt-parent = <&ipic>; > interrupts = <17 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
