Two nits, see below. <snip> > +static int snd_rk_mc_probe(struct platform_device *pdev) > +{ > + int ret = 0; > + struct snd_soc_card *card = &snd_soc_card_rk; > + struct device_node *np = pdev->dev.of_node; > + struct rk_es8388_drvdata *machine; > + > + machine = devm_kzalloc(&pdev->dev, sizeof(struct rk_es8388_drvdata), > + GFP_KERNEL); > + You don't need this new line here. > + if (!machine) > + return -ENOMEM; > + <snip> > +module_platform_driver(snd_rk_es8388_driver); > + > +MODULE_AUTHOR("Sjoerd Simons"); You should also add your email address near name. > +MODULE_DESCRIPTION("Rockchip es8388 machine ASoC driver"); > +MODULE_LICENSE("GPL v2"); > +MODULE_ALIAS("platform:" DRV_NAME); thanks, Daniel. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html