Hi Tejun, I think it would be a good idea to merge ahci upstream using the ahci_imx.c method for now. You already indicated that you were not against doing that for now. Oliver is working on getting a cleaner solution for this, but doing this properly takes tinme, and we would like to move forward with getting sunxi ahci support upstream in the mean time. So if it is ok with you we would like to move forward with the version initially posted. Therefor I would like to request you to review it (glossing over the platform device instantiating a platform device approach for now), and provide us with feedback so that we can do a v2 and start moving this towards the mainline kernel. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html