On Tue, Jan 10, 2017 at 08:30:14AM -0800, Andrey Smirnov wrote: > Add code to support support for "anatop-enable-bit" device-tree > property. This property translates to LINREG_ENABLE bit in real hardware > and is present on 1p1, 2p5 and 3p0 regulators on i.MX6 and 1p0d regulator > on i.MX7. > > Cc: yurovsky@xxxxxxxxx > Cc: Liam Girdwood <lgirdwood@xxxxxxxxx> > Cc: Mark Brown <broonie@xxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Mark Rutland <mark.rutland@xxxxxxx> > Cc: Shawn Guo <shawnguo@xxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx> > --- > > Note: "anatop-enable-bit" has already found its way into upstream tree > before this patch (probably not on purpose). See imx6ul.dtsi and > imx7s.dtsi for concrete examples But since the kernel is not using it, it doesn't really mean we have to keep it. Yes, other OSs could be, but that's unlikely. > .../devicetree/bindings/regulator/anatop-regulator.txt | 1 + > drivers/regulator/anatop-regulator.c | 12 ++++++++++++ > 2 files changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/anatop-regulator.txt b/Documentation/devicetree/bindings/regulator/anatop-regulator.txt > index 37c4ea0..1d58c8c 100644 > --- a/Documentation/devicetree/bindings/regulator/anatop-regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/anatop-regulator.txt > @@ -14,6 +14,7 @@ Optional properties: > - anatop-delay-bit-shift: Bit shift for the step time register > - anatop-delay-bit-width: Number of bits used in the step time register > - vin-supply: The supply for this regulator > +- anatop-enable-bit: Regulator enable bit offset Looks like we have several properties describing the register layout. IMO, we should drop all of them and use the compatible strings to determine those instead. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
