Hi Pavel, On Wed, Jan 11, 2017 at 11:06:48PM +0100, Pavel Machek wrote: > > > > +- clock-inv: Clock or strobe signal inversion. > > > > + Possible values: 0 -- not inverted; 1 -- inverted > > > > > > "invert" assumes I know what is normal and I do not. Define what is > > > "normal" and name the property the opposite of that. If normal is data > > > shifted on clock rising edge, then call the the property > > > "clock-shift-falling-edge" for example.. > > > > The hardware documentation says this is the "strobe/clock inversion control > > signal". I'm not entirely sure whether this is just signal polarity (it's a > > differential signal) or inversion of an internal signal of the CCP2 block. > > > > It might make sense to make this a private property for the OMAP 3 ISP > > instead. If it's seen elsewhere, then think about it again. I doubt it > > would, as CCP2 is an old bus that's used on Nokia N9, N950 and N900. > > > > As strobe is included, I'd add that to the name. Say, > > "ti,clock-strobe-inv". > > Hmm. N900 does not use inversion. Would it make sense to simply > hardcode it to "not-inverted" for now? > > Device tree changes are PITA :-(. I can't remember what's used for the N9 secondary camera. As you said, we can always add it if needed though. So works for me. -- Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
