2017-01-12 1:26 GMT+09:00 Krzysztof Kozlowski <krzk@xxxxxxxxxx>: > On Wed, Jan 11, 2017 at 09:55:48AM +0900, Chanwoo Choi wrote: >> This patch replaces the small letter of base address, offset and hex value >> with the capital letter to keep the consistency on Exynos5433. >> >> Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> >> --- >> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 14 +++++++------- >> 1 file changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> index abaf6b4d599d..d7ed1a68b6fd 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> @@ -231,7 +231,7 @@ >> compatible = "arm,psci"; >> method = "smc"; >> cpu_off = <0x84000002>; >> - cpu_on = <0xC4000003>; >> + cpu_on = <0xc4000003>; > > There is no point of such "improvements". This is just unnecessary > churn. > > Sometimes such things are accepted as part of some bigger work (vide > recent Andrzej's sysmmu for HDMI/TV). But on its own? No sense at all. Do you mean that this patch is not reasonable? or The modification of cpu_on property is only not reasonable? It is simple for the consistency to use the hex value in dts file. -- Best Regards, Chanwoo Choi Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html