On Friday 06 January 2017 10:03 AM, David Lechner wrote: > + beeper { > + compatible = "pwm-beeper"; > + pinctrl-names = "default"; > + pinctrl-0 = <&ehrpwm0b_pins>, <&_pins>; > + pwms = <&ehrpwm0 1 0 0>; > + enable-gpios = <&gpio 111 GPIO_ACTIVE_HIGH>; Since the enable-gpios binding for pwm beeper is still not accepted, can you drop the property or the node itself (if that makes more sense)? > +&spi0 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>, <&spi0_cs3_pin>; > + > + flash@0 { > + compatible = "n25q128a13", "jedec,spi-nor"; > + reg = <0>; > + spi-max-frequency = <50000000>; > + ti,spi-wdelay = <8>; > + > + /* Partitions are based on the official firmware from LEGO */ > + partitions { > + #address-cells = <1>; > + #size-cells = <1>; > + partition@0 { > + label = "U-Boot"; > + reg = <0 0x40000>; > + }; > + > + partition@40000 { > + label = "U-Boot Env"; > + reg = <0x40000 0x10000>; > + }; > + > + partition@50000 { > + label = "Kernel"; > + reg = <0x50000 0x200000>; > + }; > + > + partition@250000 { > + label = "Filesystem"; > + reg = <0x250000 0xa50000>; > + }; > + > + partition@cb0000 { > + label = "Storage"; > + reg = <0xcb0000 0x2f0000>; > + }; > + }; > + }; > + > + adc@3 { > + compatible = "ti-ads7957"; So looks like this works because of_register_spi_device() sets up modalias of spi device from compatible string. I am fine with it, just highlighting it here to make sure this is acceptable practice. I did not really find any precedence for using SPI device name as compatible property in existing DTS files. > + reg = <3>; > + spi-max-frequency = <10000000>; > + refin-supply = <&adc_ref>; > + }; Rest of the patch looks good to me. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html