* Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> [170109 10:30]:
> Hello!
>
> On 01/09/2017 07:38 PM, Alexandre Bailon wrote:
>
> > da8xx driver is registering and using the cppi dma controller but actually,
> > the da8xx has a cppi41 dma controller.
> > Update the driver to register and use the cppi41 dma controller.
> >
> > Signed-off-by: Alexandre Bailon <abailon@xxxxxxxxxxxx>
> > ---
> > drivers/usb/musb/da8xx.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c
> > index e89708d..74dcc07 100644
> > --- a/drivers/usb/musb/da8xx.c
> > +++ b/drivers/usb/musb/da8xx.c
> > @@ -458,14 +458,14 @@ static inline u8 get_vbus_power(struct device *dev)
> > }
> >
> > static const struct musb_platform_ops da8xx_ops = {
> > - .quirks = MUSB_DMA_CPPI | MUSB_INDEXED_EP,
>
> Grr, MUSB_DMA_CPPI is certainly wrong! There's no CPPI 3.0 support for
> DA8xx. Where have this come from?
>
> > + .quirks = MUSB_DMA_CPPI41 | MUSB_INDEXED_EP,
> > .init = da8xx_musb_init,
> > .exit = da8xx_musb_exit,
> >
> > .fifo_mode = 2,
> > -#ifdef CONFIG_USB_TI_CPPI_DMA
> > - .dma_init = cppi_dma_controller_create,
> > - .dma_exit = cppi_dma_controller_destroy,
>
> Likewise, WTF?
> I suggest that you fix this crap in a separate commit, to be backported
> to -stable if needed.
Probably came from my DMA patch 7f6283ed6fe8 ("usb: musb: Set up function
pointers for DMA"). At that point I thought da8xxx.c and davinci.c are just
separate attempts of the same driver.. Sorry the number of musb glue layers
is just too confusing.
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
