On Fri, Jan 06, 2017 at 04:59:14PM +0900, Andi Shyti wrote:
> Hi,
>
> On Fri, Jan 06, 2017 at 09:09:11AM +0200, Krzysztof Kozlowski wrote:
> > On Fri, Jan 06, 2017 at 12:59:06PM +0900, Jaechul Lee wrote:
> > > From: Andi Shyti <andi.shyti@xxxxxxxxxxx>
> > >
> > > Currently tm2e dts includes tm2 but there are some differences
> > > between the two boards and tm2 has some properties that tm2e
> > > doesn't have.
> > >
> > > That's why it's important to keep the two dts files independent
> > > and put all the commonalities in a tm2-common.dtsi file.
> > >
> > > At the current status the only two differences between the two
> > > dts files (besides the board name) are ldo31 and ldo38.
> > >
> > > Signed-off-by: Andi Shyti <andi.shyti@xxxxxxxxxxx>
> > > Signed-off-by: Jaechul Lee <jcsing.lee@xxxxxxxxxxx>
> > > ---
> > > .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 1118 +++++++++++++++++++
> > > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 1153 +-------------------
> >
> > Like talking to a wall. Without any feedback. If my instructions were
> > wrong (and it is not possible to detect rename) then please say it (you
> > can add personal comments after separator ---).
>
> no Krzysztof, I'm sorry, but this patch has been formatted with
> the diff algorithm *you* asked, -B50% both version 2 (where you
> didn't comment) and version 3. If you still don't like it, please
> don't blame me, blame the algorithm.
If you wrote it in cover letter or after '---' I wouldn't complain
because I would know that my feedback was ignored. But here it is like
black hole - I do not know whether I was ignored or it was not working.
>
> Now we can stay here at trying random diff algorithms (as they
> give more or less the same result) or you tell me which exact
> algorithm you want me to use. Besides, for me it's clear,
> tm2-common is all new, while in tm2 you have on one side the '-'
> (if it applies nothing has changed) on the bottom the '+'.
Maybe that depends on the git?
$ git --version
git version 2.9.3
$ git format-patch -2 -B50%
...
21 ...ynos5433-tm2.dts => exynos5433-tm2-common.dtsi} | 24 +-
22 arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 1153 +-------------------
23 arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 22 +-
24 3 files changed, 56 insertions(+), 1143 deletions(-)
25 copy arch/arm64/boot/dts/exynos/{exynos5433-tm2.dts => exynos5433-tm2-common.dtsi} (98%)
26 rewrite arch/arm64/boot/dts/exynos/exynos5433-tm2.dts (98%)
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
