On Thu, Jan 5, 2017 at 12:20 PM, Hoegeun Kwon <hoegeun.kwon@xxxxxxxxxxx> wrote: > This patch add support for MIPI-DSI based S6E3HA2 AMOLED panel > driver. This panel has 1440x2560 resolution in 5.7-inch physical > panel in the TM2 device. > > Signed-off-by: Donghwa Lee <dh09.lee@xxxxxxxxxxx> > Signed-off-by: Hyungwon Hwang <human.hwang@xxxxxxxxxxx> > Signed-off-by: Hoegeun Kwon <hoegeun.kwon@xxxxxxxxxxx> > Tested-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> > Reviewed-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx> > --- > .../bindings/display/panel/samsung,s6e3ha2.txt | 28 + > drivers/gpu/drm/panel/Kconfig | 6 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 754 +++++++++++++++++++++ > 4 files changed, 789 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt > create mode 100644 drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c > > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt > new file mode 100644 > index 0000000..da4c291 This should be a separate patch, preferably first one in the series. See: Documentation/devicetree/bindings/submitting-patches.txt Since you already got reviews and tests, I think you can retain them in both patches (so dt-bindings patch will have reviewed-by-Andrzej and the code will have review+tested). Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html