On 05/01/2017 07:10, Chen-Yu Tsai wrote: > On Tue, Jan 3, 2017 at 12:37 AM, Quentin Schulz > <quentin.schulz@xxxxxxxxxxxxxxxxxx> wrote: >> The CHR_CTRL1 register is made of 7 read-write bits with one being used >> to set the target voltage for battery charging. > > The description is incorrect. > > All 8 bits are read-write: > > - The highest bit enables the charger module > - Bits [6:5] set the target voltage > - Bits [4:3] set when the charge cycle ends, based on percentage > of charge current > - Bits [2:0] set the charge current > > Feel free to use the above in the commit message. > Thanks for the correction. >> >> This adds the CHRG_CTRL1 register to the list of writeable registers for >> AXP20X and AXP22X PMICs. > > You might want to add up to CHRG_CTRL3 for the AXP22x and CHRG_CTRL2 > for the AXP20x. These control additional aspects of the charger. > ACK. > AXP20X_CHRG_BAK_CTRL controls the charger for the RTC battery. You > could add this now, or let the person doing the RTC battery driver > add it. I'll let the person adding the RTC battery driver add it. Thanks, Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
