On Wednesday, January 4, 2017 9:49:51 AM CET Greentime Hu wrote: > On Tue, Jan 3, 2017 at 9:24 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > > > On Tuesday, January 3, 2017 2:05:47 PM CET Greentime Hu wrote: > > > I am not sure if atmac and moxa-art are exactly hardware compatible > > though > > > they are based on faraday ftmac. > > > It may be better if we use 2 different device tree binding documents to > > > describe for these 2 different drivers to use. > > > > They are probably slightly different, but close enough to have the same > > binding document, as there is no technical reason to have two separate > > drivers for them. The binding should be about the hardware type, not the > > way that Linux currently implements the drivers. > > > > Arnd > > > > > OK. > > How about this? > > rename > Documentation/devicetree/bindings/net/moxa,moxart-mac.txt > to > Documentation/devicetree/bindings/net/faraday,ftmac.txt > > and the content to > Faraday Ethernet Controller Sounds good. Note that you can use 'git patch -M' to produce this as a renaming patch. > > Required properties: > > - compatible : Must be "moxa,moxart-mac" or "andestech,atmac" or > "faraday,ftmac" I'd write this as compatible: Must contain "faraday,ftmac", as well as one of the SoC specific identifiers: "andestec,atmac" "moxa,moxart-mac" This makes it easier to extend, plus it makes the generic string mandatory. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
