Hi Mark, Thanks your for feedback. > -----Original Message----- > From: Mark Brown [mailto:broonie@xxxxxxxxxx] > Sent: Friday, December 13, 2013 12:52 AM > To: Yang, Wenyou > Cc: lgirdwood@xxxxxxxxx; grant.likely@xxxxxxxxxx; > rob.herring@xxxxxxxxxxx; vpalatin@xxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- > doc@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > plagnioj@xxxxxxxxxxxx; Ferre, Nicolas > Subject: Re: [PATCH 1/3] regulator: act8865: add PMIC(Power Management > IC) driver > > On Thu, Dec 12, 2013 at 09:18:49AM +0800, Wenyou Yang wrote: > > The main thing with this driver seems to be that it needs a bit of > modernisation to use current kernel features and APIs - there's nothing > terribly wrong from a quick glance through but it needs an update. > Details below. > > > --- a/drivers/regulator/Kconfig > > +++ b/drivers/regulator/Kconfig > > @@ -577,5 +577,12 @@ config REGULATOR_WM8994 > > This driver provides support for the voltage regulators on the > > WM8994 CODEC. > > > > +config REGULATOR_ACT8865 > > + tristate "Active-semi act8865 voltage regulator" > > + depends on I2C > > + help > > + This driver controls a active-semi act8865 voltage output > > + regulator via I2C bus. > > + > > Please keep this and the Makefile sorted. Only this one confuses me, How can I sort it? By i2c interface, by regulator type: voltage or current? Where is act8865 should be? > > > +static int act8865_read_reg(struct act8865_data *act8865, u8 reg) { > > + int ret = i2c_smbus_read_byte_data(act8865->client, reg); > > + if (ret > 0) > > + ret &= 0xff; > > + > > + return ret; > > +} > > Use regmap for register I/O and use the helpers provided by the core. > > > +static int act8865_set_voltage_sel(struct regulator_dev *rdev, u32 > > +selector) { > > + struct act8865_data *act8865 = rdev_get_drvdata(rdev); > > + int id = rdev_get_id(rdev); > > + u32 reg = act8865_vset_reg_addr(act8865, id); > > Throughout the file the indentation is a really strange mix of the first > two lines (which are the normal kernel style) and the bottom line (which > isn't). > > > + pr_info("%s: suspend voltage %dmV\n", rdev->desc->name, uV / 1000); > > Remove noisy logging like this. > > > + rdev[i] = regulator_register(&act8865_reg[id], &config); > > devm_regulator_register(). > > > +static int __init act8865_pmu_init(void) { > > + return i2c_add_driver(&act8865_pmu_driver); > > +} > > +subsys_initcall(act8865_pmu_init); > > module_i2c_driver(). Others is OK for me, I will modify, and send out new version. Thanks again. Best Regards, Wenyou Yang -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
